Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): disable coalescing of native events #646

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fredrifoUni
Copy link

Description

Disable native event coalescing by setting canCoalesce to false. This library uses a single event definition for multiple events. If they happen almost at the same time, some events would otherwise get ignored.

Related issues

N/A

Release Summary

android: Fix issue where some native events may not be triggered

Checklist

  • I read the Contributor Guide
    and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in __tests__e2e__
    • jest tests added or updated in __tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-google-mobile-ads is great? Please consider supporting the project with any of the below:

  • 👉 Star this repo on GitHub ⭐️
  • 👉 Follow Invertase on Twitter

Copy link

docs-page bot commented Oct 16, 2024

To view this pull requests documentation preview, visit the following URL:

docs.page/invertase/react-native-google-mobile-ads~646

Documentation is deployed and generated using docs.page.

@CLAassistant
Copy link

CLAassistant commented Oct 16, 2024

CLA assistant check
All committers have signed the CLA.

@mikehardy
Copy link
Collaborator

Wow that looks like a subtle one to bump in to and the change seems like it makes sense after looking through related items in react-native repo

A quick look for "onnativeevent" in the repo indicates this may be needed on the iOS side as well perhaps? There is a banner ad view component with event emitter that seems to hook into that machinery

@fredrifoUni
Copy link
Author

@mikehardy Hmm, it's possible that a similar patch is needed for iOS. We only ran into this issue on Android though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants