-
-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: smarter error logging #50
Conversation
To view this pull requests documentation preview, visit the following URL: docs.page/invertase/react-native-google-ads~50 Documentation is deployed and generated using docs.page. |
Codecov Report
@@ Coverage Diff @@
## main #50 +/- ##
=======================================
Coverage 19.46% 19.46%
=======================================
Files 22 22
Lines 663 663
Branches 166 166
=======================================
Hits 129 129
Misses 416 416
Partials 118 118 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it - one tiny comment about API harmony across the platforms, but it's an internal API so that's minor. The real purpose of the change I like a lot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I would go with squash merge for a clean commit history on main branch, once CI passes
## [3.4.0](v3.3.0...v3.4.0) (2021-12-29) ### Features * smarter error logging ([#50](#50)) ([c9c4d3b](c9c4d3b))
🎉 This PR is included in version 3.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
## [3.4.0](invertase/react-native-google-mobile-ads@v3.3.0...v3.4.0) (2021-12-29) ### Features * smarter error logging ([#50](invertase/react-native-google-mobile-ads#50)) ([c9c4d3b](invertase/react-native-google-mobile-ads@c9c4d3b))
Description
This makes use of the messages that the google mobile ads sdk already provides on error objects.
So there is no need anymore to provide custom messages.