Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: smarter error logging #50

Merged
merged 9 commits into from
Dec 29, 2021
Merged

Conversation

dylancom
Copy link
Collaborator

Description

This makes use of the messages that the google mobile ads sdk already provides on error objects.
So there is no need anymore to provide custom messages.

@docs-page
Copy link

docs-page bot commented Dec 29, 2021

To view this pull requests documentation preview, visit the following URL:

docs.page/invertase/react-native-google-ads~50

Documentation is deployed and generated using docs.page.

@codecov
Copy link

codecov bot commented Dec 29, 2021

Codecov Report

Merging #50 (23f361e) into main (a92d99d) will not change coverage.
The diff coverage is n/a.

❗ Current head 23f361e differs from pull request most recent head b581d36. Consider uploading reports for the commit b581d36 to get more accurate results

@@           Coverage Diff           @@
##             main      #50   +/-   ##
=======================================
  Coverage   19.46%   19.46%           
=======================================
  Files          22       22           
  Lines         663      663           
  Branches      166      166           
=======================================
  Hits          129      129           
  Misses        416      416           
  Partials      118      118           

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it - one tiny comment about API harmony across the platforms, but it's an internal API so that's minor. The real purpose of the change I like a lot

@dylancom dylancom requested a review from mikehardy December 29, 2021 14:47
Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I would go with squash merge for a clean commit history on main branch, once CI passes

@mikehardy mikehardy added the workflow: pending merge Waiting on CI or question responses to merge, but otherwise ready label Dec 29, 2021
@dylancom dylancom merged commit c9c4d3b into invertase:main Dec 29, 2021
@dylancom dylancom deleted the smarter-error-logging branch December 29, 2021 15:11
github-actions bot pushed a commit that referenced this pull request Dec 29, 2021
## [3.4.0](v3.3.0...v3.4.0) (2021-12-29)

### Features

* smarter error logging ([#50](#50)) ([c9c4d3b](c9c4d3b))
@mikehardy
Copy link
Collaborator

🎉 This PR is included in version 3.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mikehardy mikehardy removed the workflow: pending merge Waiting on CI or question responses to merge, but otherwise ready label Jun 24, 2022
Star-dev325 added a commit to Star-dev325/react-native-google-mobile-ads that referenced this pull request Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants