Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve outbound requests info #33

Merged
merged 3 commits into from
Dec 11, 2021

Conversation

dylancom
Copy link
Collaborator

Description

Currently the docs make it seem like setting setRequestConfiguration is mandatory.
Actually it's only needed if your app requires specific targeting or you need to provide testID's.

@docs-page
Copy link

docs-page bot commented Dec 11, 2021

To view this pull requests documentation preview, visit the following URL:

docs.page/invertase/react-native-google-ads~33

Documentation is deployed and generated using docs.page.

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

just some wording changes to clarify even more that defaults exist, and this is just to go custom
and then to emphasize that if you go custom, it must be before requests

what do you think?

docs/index.mdx Outdated Show resolved Hide resolved
docs/index.mdx Outdated Show resolved Hide resolved
dylancom and others added 2 commits December 11, 2021 20:29
Co-authored-by: Mike Hardy <[email protected]>
Co-authored-by: Mike Hardy <[email protected]>
@mikehardy mikehardy merged commit 7c4812b into invertase:main Dec 11, 2021
@mikehardy
Copy link
Collaborator

🎉 This PR is included in version 2.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants