Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect rn config path #26

Merged

Conversation

dylancom
Copy link
Collaborator

@dylancom dylancom commented Dec 9, 2021

Description

Currently the google-ads config in app.json is ignored because the path to react-native.config.js is incorrect.

@docs-page
Copy link

docs-page bot commented Dec 9, 2021

To view this pull requests documentation preview, visit the following URL:

docs.page/invertase/react-native-google-ads~26

Documentation is deployed and generated using docs.page.

@codecov
Copy link

codecov bot commented Dec 9, 2021

Codecov Report

Merging #26 (5664f59) into main (cd8fbb1) will not change coverage.
The diff coverage is n/a.

❗ Current head 5664f59 differs from pull request most recent head 9ba6e64. Consider uploading reports for the commit 9ba6e64 to get more accurate results

@@           Coverage Diff           @@
##             main      #26   +/-   ##
=======================================
  Coverage   19.00%   19.00%           
=======================================
  Files          21       21           
  Lines         658      658           
  Branches      165      165           
=======================================
  Hits          125      125           
  Misses        414      414           
  Partials      119      119           

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All mine, that one.thanks

@mikehardy
Copy link
Collaborator

Huh. Patch package should be working now as a CI job, since it's published. Will have to check. But rest of CI is working at least. A quick check if on device functionality would have caught this as well, need to get jet-next out the door

@mikehardy mikehardy merged commit 41a8eca into invertase:main Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants