-
-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(rewarded interstitial, ios): fixed false error with valid event type value #148
Conversation
Codecov Report
@@ Coverage Diff @@
## main #148 +/- ##
==========================================
- Coverage 22.73% 22.70% -0.02%
==========================================
Files 34 34
Lines 801 802 +1
Branches 196 197 +1
==========================================
Hits 182 182
- Misses 619 620 +1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for finding this issue! I'm surprised that we haven't tested this case. Sorry, this library is fast-growing library, so there's still some rough-edges 🙏. I'll merge this after the workflows are passed.
@parasdaryanani I would be appreciated if you run |
@parasdaryanani We ask that you sign our Contributor License Agreement before we can accept your contribution. |
@parasdaryanani thanks so much for the help! |
🎉 This PR is included in version 6.2.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
### [6.2.5](invertase/react-native-google-mobile-ads@v6.2.4...v6.2.5) (2022-05-14) ### Bug Fixes * fix ad inspector callback error ([c652d5e](invertase/react-native-google-mobile-ads@c652d5e)) * fix false error in rewarded interstitial with valid event type value ([#148](invertase/react-native-google-mobile-ads#148)) ([7ee21bf](invertase/react-native-google-mobile-ads@7ee21bf))
Description
Rewarded interstitial ads seem to throw an error when creating an event listener, even though the event type is valid.
Related issues
Fixes #147
Release Summary
Checklist
and followed the process outlined there for submitting PRs.
Android
iOS
e2e
tests added or updated in__tests__e2e__
jest
tests added or updated in__tests__
Test Plan
The expected event type is
rewarded_interstitial
, although error checkingBefore:
After:
Think
react-native-google-mobile-ads
is great? Please consider supporting the project with any of the below:Invertase
on Twitter