Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: test extensions / enhancements #108

Merged
merged 7 commits into from
Apr 8, 2022
Merged

Conversation

mikehardy
Copy link
Collaborator

Nothing in here is functional in the library, it is just extra test code to exercise more of the hooks + hook features and add lots of state logging so an example user can see clearly what is going on

I used this to exercise the hooks code in PR #100

@mikehardy
Copy link
Collaborator Author

It's not great form for a maintainer to just merge their code - we need review too! - but this is literally nothing but test code, and mostly just log statements on top of that. So I'll merge it pending CI

@mikehardy mikehardy added the workflow: pending merge Waiting on CI or question responses to merge, but otherwise ready label Apr 8, 2022
@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #108 (a1c38c0) into main (0bd7ce8) will not change coverage.
The diff coverage is n/a.

❗ Current head a1c38c0 differs from pull request most recent head 020ecc8. Consider uploading reports for the commit 020ecc8 to get more accurate results

@@           Coverage Diff           @@
##             main     #108   +/-   ##
=======================================
  Coverage   20.06%   20.06%           
=======================================
  Files          29       29           
  Lines         733      733           
  Branches      189      189           
=======================================
  Hits          147      147           
  Misses        586      586           

@mikehardy mikehardy force-pushed the @mikehardy/test-updates-fixes branch from bcd5af8 to 020ecc8 Compare April 8, 2022 21:11
@mikehardy
Copy link
Collaborator Author

Took the opportunity to run refresh-example.sh to get a fresh RN68 example and then re-verify everything with the new logging.

Rewarded Ads never seem to fill on iOS (they never have?), but everything else works on both platforms.

@mikehardy
Copy link
Collaborator Author

I asked the SDK forum about iOS rewarded ad no-fills: https://groups.google.com/g/google-admob-ads-sdk/c/5ixRSHOkhHE

@mikehardy mikehardy merged commit 04b18db into main Apr 8, 2022
@mikehardy mikehardy removed the workflow: pending merge Waiting on CI or question responses to merge, but otherwise ready label Apr 8, 2022
@mikehardy mikehardy deleted the @mikehardy/test-updates-fixes branch April 8, 2022 21:56
@mikehardy
Copy link
Collaborator Author

🎉 This PR is included in version 5.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant