Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔥[🐛] Parameter must be descendant of view crash #55

Closed
TaylorDale opened this issue Jan 22, 2022 · 2 comments
Closed

🔥[🐛] Parameter must be descendant of view crash #55

TaylorDale opened this issue Jan 22, 2022 · 2 comments

Comments

@TaylorDale
Copy link
Contributor

Code in AdmobBanner view manager potentially causing app crashes, solution may need to be inserted around this line:

https://github.com/invertase/react-native-google-ads/blob/2e5987aee8fa34855c657950ae36323a136b3aae/android/src/main/java/io/invertase/googleads/ReactNativeGoogleAdsBannerAdViewManager.java#L116

See discussion here ( facebook/react-native#32649 (comment) ), where there has been a fix suggested for the firebase/admob 11.5.0 release. Code appears to be the same/similar here, worth adding this fix?

@mikehardy
Copy link
Collaborator

Thanks for logging this, especially with the detailed references. Indeed, the code is right from react-native-firebase/admob 11.5 so unless the code was specifically altered here (check git blame for the forward port changes) then it'll be the same and have the same problems.

Care to post a PR with the change? Looks like a one-liner...

@TaylorDale
Copy link
Contributor Author

On it!

TaylorDale added a commit to TaylorDale/react-native-google-ads that referenced this issue Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants