fix(auth, types): instantiating OAuthProvider returns OAuthProvider #8231
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
previously 'new' on OAuthProvider returned AuthProvider which had none of the necessary OAuthProvider interface methods
Our types stray pretty far from firebase-js-sdk here, they do not allow you to
new
an OAuthProvider, however, their OAuthProvider does participate in a type inheritance chain that goes to BaseOAuthProvider, to FederatedAuthProvider which implements AuthProvider. So this change at least brings us slightly more into harmonyhttps://github.com/firebase/firebase-js-sdk/blob/144bc370942f1bdd00f482b40df2581e7ed83a0a/packages/auth/src/core/providers/oauth.ts#L63-L65
Related issues
Discussed
Release Summary
single conventional commit
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter