Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): add misconfiguration warning for missing native module #8106

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

mikehardy
Copy link
Collaborator

Description

This case comes up frequently and adds to support load when an error message could provide a pointer

Related issues

Related discussion #8102

Release Summary

Single conventional commit, rebase merge should work

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

Make sure e2e still runs - the event emitter is used everywhere so that will cover it in the normal case


Think react-native-firebase is great? Please consider supporting the project with any of the below:

Copy link

vercel bot commented Oct 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 1:33pm

@mikehardy mikehardy merged commit b038dbc into main Oct 31, 2024
18 of 19 checks passed
@mikehardy mikehardy deleted the @mikehardy/nativeemitter-non-null branch October 31, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants