-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: bump e2e test runner to React Native 0.74.1
#7985
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
russellwheatley
changed the title
test: make RN + RN macOS same version (0.74.1)
test: bump e2e test runner to React Native 0.74.1
Aug 20, 2024
russellwheatley
changed the title
test: bump e2e test runner to React Native 0.74.1
test: bump e2e test runner to React Native Aug 20, 2024
0.74.1
Lyokone
previously approved these changes
Sep 2, 2024
exaby73
approved these changes
Sep 2, 2024
Lyokone
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
0.74.1
.Fixes required for react-native-macos
0.74.1
. Required for test runner for Firebase Storage macOS as we use ArrayBuffer here.0.74.1
.We're skipping StorageReference tests on macOS. It is fragile because of
uploadBytesResumable()
. Attempted multiple ways of encoding data (Blob, Uint8Array & ArrayBuffer) but to no avail. This issue is roughly what is happening.To be specific, it is the way that
uploadBytesResumable()
interacts with React Native. There is an incompatibility issue with the way the upload request is handled when specifically uploading buffers/blobs. Using a Blob results in a crash 100% of the time, using ArrayBuffer is more stable but still crashes from time to time. Even worse is that the resulting string is encoded in base64 in the text file created.On web, this code results in a text file with correct content (i.e. "hello world"):
On react native, it is base64 encoded, even with "text/plain" content type.
Worth keeping an eye on React Native for
ArrayBuffer
implementation. See: facebook/react-native#41170Related issues
Release Summary
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter