Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(analytics): allow custom event parameters for Item in events #7908

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Pietahr
Copy link

@Pietahr Pietahr commented Jul 15, 2024

Description

We wanted to add custom parameters to the items for ecommerce events. Firebase supports it (https://developers.google.com/analytics/devguides/collection/ga4/item-scoped-ecommerce), but it was not yet supported by react-native-firebase.
This MR is inspired by #5811

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

I added a test case.


Think react-native-firebase is great? Please consider supporting the project with any of the below:

Copy link

vercel bot commented Jul 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 5:02pm

@CLAassistant
Copy link

CLAassistant commented Jul 15, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

@github-actions github-actions bot added the Stale label Aug 13, 2024
packages/analytics/lib/index.d.ts Outdated Show resolved Hide resolved
packages/analytics/lib/structs.js Show resolved Hide resolved
Copy link

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

@github-actions github-actions bot added the Stale label Sep 30, 2024
@dannyBies
Copy link

This is something I'm looking to use as well. Is there anything I can do to help this across the line?

@mikehardy mikehardy force-pushed the @pietahr/item-custom-parameters branch from 97888bf to c19c009 Compare October 2, 2024 16:57
@mikehardy mikehardy changed the title fix(analytics): allow custom event parameters for Item in events feat(analytics): allow custom event parameters for Item in events Oct 2, 2024
@mikehardy
Copy link
Collaborator

Hey @dannyBies 👋 the commit trail in here was a mess and it had one unaddressed commit
both were trivial to fix up though, faster than talking about it really so I just squashed the commits down to the change only, with an updated type per request from @russellwheatley

So if Russell re-reviews and agrees this is good to go

Either way, my re-push had the side effect of re-running CI which means that the patch-package workflow re-runs and - if you follow the details link and check the summary of the patch packages worfklow you should find a patch set you can apply to your project that will work. Providing feedback on how it works is very useful

@dannyBies
Copy link

Amazing, thanks for the extremely quick response, it's much appreciated!

I'll have a look at using patch-package tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants