-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(app)!: ios-sdk 10.25.0 (Xcode 15.2+) / android-sdk 33 (minSdk21 + 23 for auth / compileSdk 34+) #7774
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
82bfe97
to
1c82c9a
Compare
c176364
to
a77d8f0
Compare
This one has everything working except a hang in the iOS messaging e2e that may be the #7272 issue |
03f43e9
to
4ed5e7f
Compare
4ed5e7f
to
65dc001
Compare
65dc001
to
2051ca8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7774 +/- ##
===========================================
+ Coverage 23.52% 69.87% +46.36%
===========================================
Files 134 150 +16
Lines 5570 5984 +414
Branches 1258 1255 -3
===========================================
+ Hits 1310 4181 +2871
+ Misses 3572 1714 -1858
+ Partials 688 89 -599 |
0153105
to
823b377
Compare
823b377
to
61585d2
Compare
BREAKING CHANGE: firebase-ios-sdk 10.25.0 requires minimum Xcode 15.2+ This transitively requires macOS Ventura 13.5+ - for old hardware you may investigate OCLP (OpenCore Legacy Patcher) to update macOS to current versions and access newer Xcode versions
note that this would only be used if you built the module directly, that is, not in the context of an app, so no one would notice this change in practice / normal usage
there was only one usage of Guava in firestore, and it was easily replaced with a for loop which eliminates the dependency this is important in the context of firebase-android-sdk where guava is no longer transitively available - best to remove it here as well vs bring it in directly as a dependency we specifically we need
…uth) BREAKING CHANGE: - requires minSdk 21+ in general, 23+ for auth module - requires compileSdk 34+ - app-distribution gradle plugin requires - gradle 7.3+ - android gradle plugin 7+ - google services plugin 4.3.2+ - crashlytics plugin requires - gradle 8+ - android gradle plugin 8.1+ - google services plugin 4.4.1+
61585d2
to
2057e38
Compare
Description
Adopt firebase-ios-sdk 10.25.0
Adopt firebase-android-sdk 33.0.0
Related issues
Continues to help with iOS privacy requirements from Apple
Lots of new goodies in android that we can expose here later, and lots of transitive deps updated
Release Summary
Has breaking changes commit snecessary for conventional-commits / semantic release but the important bits are:
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
Run e2e tests locally, ensure they pass
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter