Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app)!: ios-sdk 10.25.0 (Xcode 15.2+) / android-sdk 33 (minSdk21 + 23 for auth / compileSdk 34+) #7774

Merged
merged 8 commits into from
May 20, 2024

Conversation

mikehardy
Copy link
Collaborator

@mikehardy mikehardy commented May 1, 2024

Description

Adopt firebase-ios-sdk 10.25.0
Adopt firebase-android-sdk 33.0.0

Related issues

Continues to help with iOS privacy requirements from Apple
Lots of new goodies in android that we can expose here later, and lots of transitive deps updated

Release Summary

Has breaking changes commit snecessary for conventional-commits / semantic release but the important bits are:

  • that we have a new Xcode 15.2 minimum dependency (and transitively macOS 13.5) and
  • android minSdk is now 21 (23 for auth!) as well as compileSdk 34

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

Run e2e tests locally, ensure they pass


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@mikehardy mikehardy added the Workflow: Pending Merge Waiting on CI or similar label May 1, 2024
Copy link

vercel bot commented May 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 20, 2024 2:57am

@mikehardy
Copy link
Collaborator Author

This one has everything working except a hang in the iOS messaging e2e that may be the #7272 issue

@mikehardy mikehardy added the Workflow: Needs Review Pending feedback or review from a maintainer. label May 3, 2024
@mikehardy mikehardy changed the title feat(app, ios)!: adopt firebase-ios-sdk 10.25.0 requires Xcode 15.2+ feat(app)!: ios-sdk 10.25.0 (needs Xcode 15.2+) / android-sdk 33 (needs minSdk21 + 23 for auth / compileSdk 34+) May 7, 2024
@mikehardy mikehardy force-pushed the @mikehardy/dependency-updates branch from 03f43e9 to 4ed5e7f Compare May 7, 2024 22:55
@mikehardy mikehardy force-pushed the @mikehardy/dependency-updates branch from 4ed5e7f to 65dc001 Compare May 8, 2024 01:31
@mikehardy mikehardy force-pushed the @mikehardy/dependency-updates branch from 65dc001 to 2051ca8 Compare May 8, 2024 01:41
@mikehardy mikehardy changed the title feat(app)!: ios-sdk 10.25.0 (needs Xcode 15.2+) / android-sdk 33 (needs minSdk21 + 23 for auth / compileSdk 34+) feat(app)!: ios-sdk 10.25.0 (Xcode 15.2+) / android-sdk 33 (minSdk21 + 23 for auth / compileSdk 34+) May 8, 2024
Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.87%. Comparing base (edac622) to head (61585d2).

Current head 61585d2 differs from pull request most recent head 2057e38

Please upload reports for the commit 2057e38 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #7774       +/-   ##
===========================================
+ Coverage   23.52%   69.87%   +46.36%     
===========================================
  Files         134      150       +16     
  Lines        5570     5984      +414     
  Branches     1258     1255        -3     
===========================================
+ Hits         1310     4181     +2871     
+ Misses       3572     1714     -1858     
+ Partials      688       89      -599     

mikehardy added 8 commits May 19, 2024 21:50
BREAKING CHANGE: firebase-ios-sdk 10.25.0 requires minimum Xcode 15.2+

This transitively requires macOS Ventura 13.5+ - for old hardware
you may investigate OCLP (OpenCore Legacy Patcher) to update macOS
to current versions and access newer Xcode versions
note that this would only be used if you built the module directly,
that is, not in the context of an app, so no one would notice this
change in practice / normal usage
there was only one usage of Guava in firestore, and it was easily
replaced with a for loop which eliminates the dependency

this is important in the context of firebase-android-sdk where guava
is no longer transitively available - best to remove it here as well
vs bring it in directly as a dependency we specifically we need
…uth)

BREAKING CHANGE:
- requires minSdk 21+ in general, 23+ for auth module
- requires compileSdk 34+
- app-distribution gradle plugin requires
  - gradle 7.3+
  - android gradle plugin 7+
  - google services plugin 4.3.2+
- crashlytics plugin requires
  - gradle 8+
  - android gradle plugin 8.1+
  - google services plugin 4.4.1+
@mikehardy mikehardy force-pushed the @mikehardy/dependency-updates branch from 61585d2 to 2057e38 Compare May 20, 2024 02:53
@mikehardy mikehardy merged commit 4057484 into main May 20, 2024
18 checks passed
@mikehardy mikehardy deleted the @mikehardy/dependency-updates branch May 20, 2024 03:48
@mikehardy mikehardy removed the Workflow: Pending Merge Waiting on CI or similar label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant