-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ios enrollmentDate -> enrollmentTime #7653
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rename `enrollmentDate` -> `enrollmentTime` on iOS to match Android/Web (ref: https://firebase.google.com/docs/reference/js/auth.multifactorinfo) keep `enrollmentDate` around on ios for backwards compatibility, mark as deprecated. ref: - https://github.com/invertase/react-native-firebase/blob/main/packages/auth/android/src/main/java/io/invertase/firebase/auth/ReactNativeFirebaseAuthModule.java#L2500 - https://github.com/invertase/react-native-firebase/blob/main/packages/auth/lib/index.d.ts#L483 split from invertase#7565
5dbb1fd
to
ec3ea1b
Compare
@mikehardy I've adjusted this to be backwards compatible since I missed the v19 release, it would be great if you could take a look 🙏 |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #7653 +/- ##
===========================================
- Coverage 68.05% 33.23% -34.82%
===========================================
Files 149 251 +102
Lines 5943 12463 +6520
Branches 1250 1944 +694
===========================================
+ Hits 4044 4141 +97
- Misses 1802 8233 +6431
+ Partials 97 89 -8 |
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 15 days until this gets closed automatically |
still alive |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Easy approve as it's backwards compatible, thank you!
Description
rename
enrollmentDate
->enrollmentTime
on iOS to match Android/Web (ref: https://firebase.google.com/docs/reference/js/auth.multifactorinfo)keep
enrollmentDate
around on ios for backwards compatibility, mark as deprecated.ref:
BREAKING CHANGE:
enrollmentDate
renamed toenrollmentTime
on iOSsplit from #7565
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__