Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(auth): un-cross docs for two states in PhoneAuthState enum #7537

Merged
merged 1 commit into from
Dec 29, 2023

Conversation

puls
Copy link
Contributor

@puls puls commented Dec 26, 2023

Description

Just fixing some documentation

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • [🔥] Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

I didn't change any code.

Copy link

vercel bot commented Dec 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 26, 2023 7:42pm
react-native-firebase-next ❌ Failed (Inspect) Dec 26, 2023 7:42pm

@CLAassistant
Copy link

CLAassistant commented Dec 26, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did those two even get crossed up !? 🤦 thank you for the fix!

@mikehardy mikehardy changed the title Fix documentation comments for PhoneAuthState enum docs(auth): un-cross docs for two states in PhoneAuthState enum Dec 28, 2023
Copy link

codecov bot commented Dec 28, 2023

Codecov Report

Merging #7537 (24efc70) into main (605a0df) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #7537   +/-   ##
=========================================
  Coverage     53.29%   53.29%           
  Complexity      738      738           
=========================================
  Files           251      251           
  Lines         12391    12391           
  Branches       1936     1936           
=========================================
  Hits           6603     6603           
  Misses         5440     5440           
  Partials        348      348           

@mikehardy mikehardy merged commit e488c5c into invertase:main Dec 29, 2023
15 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants