-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(index.md): Expo / EAS updates and fixes #7502
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@gregfenton |
I think it is still required? I kept the information about it, but moved it around a bit. The setting is in the JSON example and the paragraph about it is moved to just before the JSON example. An issue I saw when |
The way it is done in Expo may change, but the underlying requirement for |
I kept the required info, just moved it around for easier consumption by "fly-by" readers 😁 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was going to open a PR but saw this. Hope you don't mind me intervening your PR @gregfenton and hoping Mike doesn't me leaving review too (🙈 )
I've left some suggestions based on recent Expo docs changes and also how things might be going on moving forward so as to eliminate possibilities for creating confusion.
Also, I couldn't edit or suggest the introduction paragraph under Expo
so can I ask you to please update it to this:
Integration with Expo is possible with both with [development builds](https://docs.expo.dev/workflow/overview/#development-builds) or [bare workflow](https://docs.expo.dev/bare/overview/).
I think instead of calling them custom managed workflows/managed workflows, it is more appropriate now to call them just development builds.
Thank you so much, Greg, for updating this 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! Will try to shepherd this through all the CI checks right now
I made one fix as the use frameworks thing was in android instead of ios - I don't think that's controversial at all so I'm going to just commit it and get this in 🚂
Fixed a few formatting issues & divided the section into subsections for clarity in following the steps.
minor additional tweaks to simplify steps for newcomers
Co-authored-by: Aman Mittal <[email protected]>
Co-authored-by: Aman Mittal <[email protected]>
Co-authored-by: Aman Mittal <[email protected]>
Co-authored-by: Aman Mittal <[email protected]>
Co-authored-by: Aman Mittal <[email protected]>
Co-authored-by: Aman Mittal <[email protected]>
Co-authored-by: Aman Mittal <[email protected]>
(previous edit was through GH Web UI)
Fixed a few formatting issues & divided the section into subsections for clarity in following the steps.
Description
Motivation: people (mainly newcomers to Expo) in the Firebase community struggling to understand the guidance for Expo.
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter