Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(messaging): added note about notifee v7 notification event handling #7411

Merged
merged 3 commits into from
Nov 27, 2023

Conversation

RRigueira24
Copy link
Contributor

@RRigueira24 RRigueira24 commented Oct 18, 2023

Description

Adding to docs a note about notifee v7 release impacting react native firebase getInitialNotification and onNotificationsOpenedApp. See https://notifee.app/react-native/docs/release-notes#700

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

🔥

@vercel
Copy link

vercel bot commented Oct 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase 🛑 Canceled (Inspect) Nov 27, 2023 1:13pm
react-native-firebase-next 🛑 Canceled (Inspect) Nov 27, 2023 1:13pm

@CLAassistant
Copy link

CLAassistant commented Oct 18, 2023

CLA assistant check
All committers have signed the CLA.

Copy link

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

@github-actions github-actions bot added Stale and removed Stale labels Nov 15, 2023
mikehardy
mikehardy previously approved these changes Nov 27, 2023
Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the long delay here - these are valid (and Notifee still needs a lot of attention! Getting there, bit by bit...)

@mikehardy
Copy link
Collaborator

closing and reopening just to trigger CI

@mikehardy mikehardy closed this Nov 27, 2023
@mikehardy mikehardy reopened this Nov 27, 2023
mikehardy
mikehardy previously approved these changes Nov 27, 2023
Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added notifee to the spellcheck dictionary - should go green in CI now then can merge

@mikehardy mikehardy changed the title docs: added note about notifee v7 notification event handling docs(messaging): added note about notifee v7 notification event handling Nov 27, 2023
Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what can I say, passing all the various lint checks is harder than it seems!
I think I fixed the last issue - method names will be spell-checked unless in backticks

@mikehardy mikehardy merged commit 1318eaf into invertase:main Nov 27, 2023
8 of 10 checks passed
@vercel vercel bot temporarily deployed to Preview – react-native-firebase November 27, 2023 13:13 Inactive
@vercel vercel bot temporarily deployed to Preview – react-native-firebase-next November 27, 2023 13:13 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants