-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(messaging): added note about notifee v7 notification event handling #7411
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 15 days until this gets closed automatically |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the long delay here - these are valid (and Notifee still needs a lot of attention! Getting there, bit by bit...)
closing and reopening just to trigger CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added notifee to the spellcheck dictionary - should go green in CI now then can merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what can I say, passing all the various lint checks is harder than it seems!
I think I fixed the last issue - method names will be spell-checked unless in backticks
Description
Adding to docs a note about notifee v7 release impacting react native firebase getInitialNotification and onNotificationsOpenedApp. See https://notifee.app/react-native/docs/release-notes#700
Related issues
Release Summary
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter🔥