Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ml): add modular API #7390

Merged
merged 1 commit into from
Oct 15, 2023
Merged

feat(ml): add modular API #7390

merged 1 commit into from
Oct 15, 2023

Conversation

exaby73
Copy link
Contributor

@exaby73 exaby73 commented Oct 3, 2023

Description

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@vercel
Copy link

vercel bot commented Oct 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2023 0:26am
react-native-firebase-next ❌ Failed (Inspect) Oct 11, 2023 0:26am

@mikehardy
Copy link
Collaborator

rebased to main after dropping lots of fixes for ci/build/test and it should go green, still needs review (but it's so small, should be trivial!)

@codecov
Copy link

codecov bot commented Oct 14, 2023

Codecov Report

Merging #7390 (0859705) into main (3dca3c1) will increase coverage by 31.18%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #7390       +/-   ##
=============================================
+ Coverage     22.93%   54.11%   +31.18%     
- Complexity        0      738      +738     
=============================================
  Files           130      248      +118     
  Lines          5443    12163     +6720     
  Branches       1235     1897      +662     
=============================================
+ Hits           1248     6581     +5333     
- Misses         3510     5236     +1726     
+ Partials        685      346      -339     

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok - finally restarted things so everything went green, review is 💯 (as expected, it's tiny!), good to go!

@mikehardy mikehardy merged commit 2d8ac14 into main Oct 15, 2023
16 checks passed
@mikehardy mikehardy deleted the feat/ml-modular branch October 15, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants