Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(installations): Firebase JS SDK V9 modular API #7095

Merged
merged 7 commits into from
Jun 13, 2023

Conversation

exaby73
Copy link
Contributor

@exaby73 exaby73 commented May 3, 2023

Description

Adds the Firebase JS Web V9 modular API to RNFB.

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@vercel
Copy link

vercel bot commented May 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2023 7:39am
react-native-firebase-next 🔄 Building (Inspect) May 9, 2023 7:39am

@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Merging #7095 (c5eb6d3) into main (f7ec3d1) will increase coverage by 0.03%.
The diff coverage is 75.00%.

@@             Coverage Diff              @@
##               main    #7095      +/-   ##
============================================
+ Coverage     54.00%   54.02%   +0.03%     
  Complexity      734      734              
============================================
  Files           230      231       +1     
  Lines         11503    11515      +12     
  Branches       1854     1855       +1     
============================================
+ Hits           6211     6220       +9     
- Misses         4949     4952       +3     
  Partials        343      343              

@exaby73 exaby73 changed the title Feat/installations modular feat: Add v9 modular API for Firebase installations May 4, 2023
@exaby73 exaby73 changed the title feat: Add v9 modular API for Firebase installations feat(installations): Firebase JS V9 modular API May 4, 2023
@exaby73 exaby73 changed the title feat(installations): Firebase JS V9 modular API feat(installations): Firebase JS SDK V9 modular API May 4, 2023
@exaby73 exaby73 marked this pull request as ready for review May 4, 2023 16:47
@Lyokone Lyokone requested review from mikehardy and Lyokone May 9, 2023 06:10
@github-actions
Copy link

github-actions bot commented Jun 7, 2023

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

@github-actions github-actions bot added the Stale label Jun 7, 2023
@github-actions github-actions bot removed the Stale label Jun 8, 2023
@russellwheatley russellwheatley merged commit 08cb0c2 into main Jun 13, 2023
@russellwheatley russellwheatley deleted the feat/installations-modular branch June 13, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants