Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dynamic-links): add build commands to package.json #6660

Merged
merged 1 commit into from
Nov 4, 2022

Conversation

austin43
Copy link
Contributor

@austin43 austin43 commented Nov 3, 2022

Description

This pull request adds missing build commands from #6650

Related issues

#2660
#4548
#4548 (comment)

Release Summary

chore(dynamic-links): add build commands to package.json

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

To test, add the @react-native-firebase/dynamic-links plugin to the list of RNFB plugins, and verify the AppDelegate has been modified.

Functionally, real world dynamic link matching is inherently hard to test due to the end-to-end nature of the app install process. My best recommendation for testing here is

  • generate a dynamic link that points to your app that is live on the App Store
  • return to the Home Screen
  • install a dev version of your app which contains the fix
  • verify getInitialLink is called and contains your expected payload

@vercel
Copy link

vercel bot commented Nov 3, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Nov 3, 2022 at 6:23PM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
react-native-firebase-next ⬜️ Ignored (Inspect) Nov 3, 2022 at 6:23PM (UTC)

@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Merging #6660 (4724086) into main (542cec8) will increase coverage by 0.35%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #6660      +/-   ##
============================================
+ Coverage     53.72%   54.06%   +0.35%     
  Complexity      690      690              
============================================
  Files           216      216              
  Lines         10772    10772              
  Branches       1696     1696              
============================================
+ Hits           5786     5823      +37     
+ Misses         4691     4657      -34     
+ Partials        295      292       -3     

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obvious in hindsight but I missed it on review as well! Thanks for the followup

@mikehardy mikehardy merged commit 3ec3340 into invertase:main Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants