Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(auth, social): Play Store APIs required for google sign in #6606

Merged
merged 2 commits into from
Oct 17, 2022

Conversation

Uchehens
Copy link
Contributor

Description

For google authentication Google Play store is required to be installed and updated to prevents errors like [Error: A non-recoverable sign in failure occurred]

On emulator this error are common [Error: A non-recoverable sign in failure occurred] and this can be caused by the emulator not supporting Google Play Service.
To Resolve this ensure the emulator supports Google Play Service and is updated

Related issues

Bug [Error: A non-recoverable sign in failure occurred]

Release Summary

Google Pay Service is required by react-native-google-signin library

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • [ X] Yes
  • My change supports the following platforms;
    • [ X] Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

For google authentication Google Play store is required to be installed and updated to prevents errors like [Error: A non-recoverable sign in failure occurred]
@vercel
Copy link

vercel bot commented Oct 14, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Oct 17, 2022 at 2:53PM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
react-native-firebase-next ⬜️ Ignored (Inspect) Oct 17, 2022 at 2:53PM (UTC)

@CLAassistant
Copy link

CLAassistant commented Oct 14, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This brings up a good point but I'm not sure it's 100% correct though it is close - I believe the Google APIs emulator flavor will also work, I do not believe the Google Play emulator flavor is the strict requirement. I just tested it now and it worked for me.

docs/auth/social-auth.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me like this, thanks again for exposing the play APIs dependency in the docs, this should help others

@mikehardy mikehardy added the Workflow: Pending Merge Waiting on CI or similar label Oct 17, 2022
@mikehardy mikehardy changed the title For Google Authentication on Emulator Google Play Store is Required docs(auth, social): Play Store APIs required for google sign in Oct 17, 2022
@mikehardy mikehardy merged commit bf1de6c into invertase:main Oct 17, 2022
@mikehardy mikehardy added hacktoberfest-accepted Let's plant some trees! and removed Workflow: Pending Merge Waiting on CI or similar labels Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Let's plant some trees!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants