-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(database): support the new EventEmitter.js
logic of RN 0.70.0 (…
#6539
Conversation
…backwards compatible)
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
@mikehardy what's wrong with the PR Title? 🤔 |
the PR Title check now passed, weird |
Codecov Report
@@ Coverage Diff @@
## main #6539 +/- ##
=============================================
- Coverage 72.33% 54.48% -17.84%
- Complexity 0 679 +679
=============================================
Files 109 208 +99
Lines 4657 10363 +5706
Branches 1048 1648 +600
=============================================
+ Hits 3368 5645 +2277
- Misses 1211 4435 +3224
- Partials 78 283 +205 |
When there is only one commit GitHub uses the commit instead of PR title - it is a GitHub quirk and the check warns about it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for posting this!
* fix(database): support the new `EventEmitter.js` logic of RN 0.70.0 (backwards compatible) * fix(database): typo in `removeListenerRegistrations` function (cherry picked from commit 3371727)
…backwards compatible)
Description
Meta has re-written the
EventEmitter.js
on react native0.70.0
in this commit. This PR fixes this issue #6534 while keeping backwards compatibility with react-native <0.70.0
.Related issues
#6534
Release Summary
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter