Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(database): support the new EventEmitter.js logic of RN 0.70.0 (… #6539

Merged
merged 2 commits into from
Sep 15, 2022

Conversation

efstathiosntonas
Copy link
Contributor

…backwards compatible)

Description

Meta has re-written the EventEmitter.js on react native 0.70.0 in this commit. This PR fixes this issue #6534 while keeping backwards compatibility with react-native < 0.70.0.

Related issues

#6534

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@vercel
Copy link

vercel bot commented Sep 15, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-native-firebase ✅ Ready (Inspect) Visit Preview Sep 15, 2022 at 5:43AM (UTC)
1 Ignored Deployment
Name Status Preview Updated
react-native-firebase-next ⬜️ Ignored (Inspect) Sep 15, 2022 at 5:43AM (UTC)

@efstathiosntonas
Copy link
Contributor Author

@mikehardy what's wrong with the PR Title? 🤔

@efstathiosntonas
Copy link
Contributor Author

the PR Title check now passed, weird

@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Merging #6539 (0febe41) into main (f10891a) will decrease coverage by 17.85%.
The diff coverage is 0.00%.

❗ Current head 0febe41 differs from pull request most recent head 835c326. Consider uploading reports for the commit 835c326 to get more accurate results

@@              Coverage Diff              @@
##               main    #6539       +/-   ##
=============================================
- Coverage     72.33%   54.48%   -17.84%     
- Complexity        0      679      +679     
=============================================
  Files           109      208       +99     
  Lines          4657    10363     +5706     
  Branches       1048     1648      +600     
=============================================
+ Hits           3368     5645     +2277     
- Misses         1211     4435     +3224     
- Partials         78      283      +205     

@mikehardy
Copy link
Collaborator

When there is only one commit GitHub uses the commit instead of PR title - it is a GitHub quirk and the check warns about it

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for posting this!

@mikehardy mikehardy merged commit 3371727 into invertase:main Sep 15, 2022
mikehardy pushed a commit that referenced this pull request Sep 16, 2022
* fix(database): support the new `EventEmitter.js` logic of RN 0.70.0 (backwards compatible)

* fix(database): typo in `removeListenerRegistrations` function

(cherry picked from commit 3371727)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants