Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(messaging): add support for setDeliveryMetricsExportToBigQuery #6528

Conversation

pavan168
Copy link
Contributor

Description

We have had very specific requirements to send out push notifications using FCM and have implemented an in-house solution using the Firebase Admin SDK. However, we don't get access to the message delivery information in the Firebase Console anymore and want to use BigQuery to analyse this information.

Reading through the documentation we found that the message delivery data export needs to be enabled on the device (after asking for consent of course) and both ios and android native methods are not exposed as per the RNFirebase documentation.

With this PR, we can use setDeliveryMetricsExportToBigQuery method to pass down the status (a boolean value) and have used deliveryMetricsExportToBigQueryEnabled() method that exist already on android to return the updated status whilst iOS does not have a similar method, isDeliveryMetricsExportToBigQueryEnabled is introduced that holds the most up-to-date status that can be used as per your requirement.

Related issues

n/a

Release Summary

n/a

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes 🔥
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

  1. iOS test cases

ios

  1. Android test cases

android


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@vercel
Copy link

vercel bot commented Sep 13, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-native-firebase ✅ Ready (Inspect) Visit Preview Sep 13, 2022 at 4:55AM (UTC)
1 Ignored Deployment
Name Status Preview Updated
react-native-firebase-next ⬜️ Ignored (Inspect) Sep 13, 2022 at 4:55AM (UTC)

@CLAassistant
Copy link

CLAassistant commented Sep 13, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ pavan168
❌ Pavan Welihinda


Pavan Welihinda seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@pavan168
Copy link
Contributor Author

Duplicate of #6529

@pavan168 pavan168 closed this Sep 13, 2022
@pavan168 pavan168 deleted the feature/#bab4476-msg-dlvrs-expts-to-bgqry branch September 13, 2022 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants