-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(auth, phone): add link to upstream android setup instructions #5925
Conversation
This pull request is being automatically deployed with Vercel (learn more). react-native-firebase-next – ./website_modular🔍 Inspect: https://vercel.com/invertase/react-native-firebase-next/77nXESvk5LvZnuwUCjSxxmqkNwbf [Deployment for f08dc7a canceled] react-native-firebase – ./🔍 Inspect: https://vercel.com/invertase/react-native-firebase/DtL4xaGwz1XDrTEMyoDYiCVKW5PX |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! This is a good catch on a missing part, I think the SafetyNet stuff especially is semi-new upstream vs the docs and now we really need to refer upstream
Thanks for taking the time to post this, I'm sure it will help future people
This will need the CLA signed before we can merge, even though it's tiny - you may follow the details link on the CLA action or the ones in the comment from the CLA bot to get it signed, thank you! |
Just submitted I think! :) Sorry about that |
boom 💥 😄 thanks |
Description
Related issues
Release Summary
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
No tests, just adding some documentation
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter