Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(auth, phone): add link to upstream android setup instructions #5925

Merged
merged 2 commits into from
Dec 9, 2021

Conversation

dqii
Copy link
Contributor

@dqii dqii commented Dec 9, 2021

Description

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • [ x] Yes
  • My change supports the following platforms;
    • [ x] Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • [ x] No

Test Plan

No tests, just adding some documentation

Think react-native-firebase is great? Please consider supporting the project with any of the below:

@vercel
Copy link

vercel bot commented Dec 9, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

react-native-firebase-next – ./website_modular

🔍 Inspect: https://vercel.com/invertase/react-native-firebase-next/77nXESvk5LvZnuwUCjSxxmqkNwbf
✅ Preview: Canceled

[Deployment for f08dc7a canceled]

react-native-firebase – ./

🔍 Inspect: https://vercel.com/invertase/react-native-firebase/DtL4xaGwz1XDrTEMyoDYiCVKW5PX
✅ Preview: https://react-native-firebase-git-fork-dqii-patch-1-invertase.vercel.app

@vercel vercel bot temporarily deployed to Preview – react-native-firebase-next December 9, 2021 20:37 Inactive
@CLAassistant
Copy link

CLAassistant commented Dec 9, 2021

CLA assistant check)
All committers have signed the CLA.

mikehardy
mikehardy previously approved these changes Dec 9, 2021
Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This is a good catch on a missing part, I think the SafetyNet stuff especially is semi-new upstream vs the docs and now we really need to refer upstream
Thanks for taking the time to post this, I'm sure it will help future people

@mikehardy mikehardy changed the title Update phone-auth.md by adding Android instructions docs(auth, phone): add link to upstream android setup instructions Dec 9, 2021
@mikehardy mikehardy added the Workflow: Pending Merge Waiting on CI or similar label Dec 9, 2021
docs/auth/phone-auth.md Outdated Show resolved Hide resolved
@mikehardy
Copy link
Collaborator

This will need the CLA signed before we can merge, even though it's tiny - you may follow the details link on the CLA action or the ones in the comment from the CLA bot to get it signed, thank you!

@dqii
Copy link
Contributor Author

dqii commented Dec 9, 2021

Just submitted I think! :) Sorry about that

@mikehardy mikehardy merged commit b9af132 into invertase:main Dec 9, 2021
@mikehardy
Copy link
Collaborator

boom 💥 😄 thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants