Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(*): bumped test app to v7.7.0 #4951

Closed
wants to merge 1 commit into from

Conversation

dackers86
Copy link
Member

Description

The current build fails for the projects test app when rebuilding iOS pods. Bumping the version to the recently updated 7.7.0 fixes this.

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.

    • Yes
  • My change supports the following platforms;

    • Android
    • iOS
  • My change includes tests;

    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.

  • This is a breaking change;

    • Yes
    • No
  • 👉 Star this repo on GitHub ⭐️

  • 👉 Follow React Native Firebase and Invertase on Twitter

@vercel
Copy link

vercel bot commented Feb 25, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/invertase/react-native-firebase/7GEmVVff8sATE8r1HZ7NLexp1UR7
✅ Preview: https://react-native-f-git-dackers86-bump-test-app-version-in-91907b.vercel.app

@codecov
Copy link

codecov bot commented Feb 25, 2021

Codecov Report

Merging #4951 (8a22c12) into master (e173954) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4951   +/-   ##
=======================================
  Coverage   88.93%   88.93%           
=======================================
  Files         109      109           
  Lines        3721     3721           
  Branches      348      348           
=======================================
  Hits         3309     3309           
  Misses        369      369           
  Partials       43       43           

@dackers86 dackers86 changed the title chore(*) bumped test app to v7.7.0 chore(*): bumped test app to v7.7.0 Feb 25, 2021
Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one I need to think about - as we discussed, we should be able to update @react-native-firebase/app/package.json firebase-ios-sdk value by itself, then with no override here things should work. So doing an override here is possible but should not be needed, and doesn't help userbase by updating for them (with CI testing showing it then works in the test app...)

So I love the idea of bumping firebase-ios-sdk to 7.7.0 but I don't like this mechanism. I'll look at this right now to see what I can do to get 7.7.0 working all around with only an app/package.json bump

@dackers86
Copy link
Member Author

@mikehardy Thanks Mike. Sounds good to me!

@mikehardy
Copy link
Collaborator

Posted #4953 which will make it unnecessary to ever manually bump the test app sdk version, it will consume the version from app package as I meant for it to do, but incorrectly implemented previously

sorry this hung you up!

@mikehardy mikehardy closed this Feb 25, 2021
@mikehardy mikehardy deleted the @dackers86/bump-test-app-version branch February 25, 2021 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants