fix(analytics): Use correct add_to_cart event name

[andrzejbe]

triggering analytics().logAddToCart firebase event resulted in sending "addPaymentInfo" event to firebase analytics

Summary

After inspecting source code its clear this was almost a "typo" as "add_payment_info" is defined few lines above and it was probably a simple omission.

This is a simple bug - but crucial for anyone who tries to use more advanced ecommerce pre-defined firebase events (like adding/removing from cart etc. ecommerce funnels etc.).

Tested on Android - with my fix I can now send correct add_to_cart events which are then successfully registered in Firebase Analytics

Checklist

• Supports Android
• Supports iOS
• e2e tests added or updated in packages/**/e2e
• Flow types updated
• Typescript types updated

Test Plan

Release Plan

---

Think react-native-firebase is great? Please consider supporting the project with any of the below:

• 👉 Donate via Open Collective
• 👉 Follow React Native Firebase and Invertase on Twitter
• 👉 Star this repo on GitHub ⭐️
• 👉 Contribute; see our contributing guide

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

---

Andrzej Bednarczyk seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[mikehardy]

nice catch! I checked the file for any other thinkos and it looks like this was it?

[andrzejbe]

yup that was the only one - I don't use all of them, but quite a few and all the others works just fine

[codecov]

Codecov Report

Merging #2882 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2882   +/-   ##
=======================================
  Coverage   88.69%   88.69%           
=======================================
  Files         111      111           
  Lines        3437     3437           
=======================================
  Hits         3048     3048           
  Misses        389      389

[Salakar]

Yep, this looks like code to me 😅 approved

[Salakar]

Woops, thanks for sending this, will be in 6.1

[Salakar]

This is now live in v6.0.4. Thanks