Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ANDROID][BUGFIX][ADMOB] Fixing UnityAds not working with Admob Mediation #1826

Closed
wants to merge 66 commits into from

Conversation

wasedaigo
Copy link
Contributor

Fixes #1792

Summary

There is a problem that UnityAds does not work with Admob Mediation.
It seems some mediation adapters such as UnityAds, adcolony, appodeal require ActivityContext.
This PR fixes the issue.

Checklist

  • [ x] Supports Android
  • Supports iOS
  • e2e tests added or updated in /tests/e2e/*
  • Updated the documentation in the docs repo
    • LINK TO DOCS PR HERE
  • Flow types updated
  • Typescript types updated

Test Plan

My fork is already released for my games in production.
I started seeing getting a traffic to UnityAds via AdmobMediation which used to be zero.
So far I am not seeing any obvious bug due to this change, but I have no idea how to make sure this change won't introduce any regression.

Release Plan

[ANDROID][BUGFIX][ADMOB] - Fixed an issue UnityAds wasn't working with Admob Mediation due to the lack of ActivityContext

@CLAassistant
Copy link

CLAassistant commented Jan 13, 2019

CLA assistant check
All committers have signed the CLA.

@wasedaigo wasedaigo changed the base branch from master to v5.x.x February 10, 2019 01:19
…rebase"

This reverts commit 7721c58, reversing
changes made to d24e572.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants