[messaging] getToken/deleteToken/onTokenRefresh improvements #1805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Salakar
added
platform: android
platform: ios
plugin: messaging
Codecov Report
@@ Coverage Diff @@
## master #1805 +/- ##
==========================================
- Coverage 76.11% 75.15% -0.97%
==========================================
Files 72 75 +3
Lines 1838 1932 +94
==========================================
+ Hits 1399 1452 +53
- Misses 439 480 +41 |
Codecov Report
@@ Coverage Diff @@
## master #1805 +/- ##
==========================================
+ Coverage 76.11% 76.16% +0.05%
==========================================
Files 72 72
Lines 1838 1838
==========================================
+ Hits 1399 1400 +1
+ Misses 439 438 -1 |
Salakar
changed the title
…ervice) is now deprecated - swapped internally for FirebaseMessagingService->onNewToken.
Salakar
changed the title
6 tasks
blankg
pushed a commit
to blankg/react-native-firebase
that referenced
this pull request
Jan 15, 2019
…se#1805) [IOS] [BUGFIX] [MESSAGING] fix getToken() always returning initialToken (invertase#1510) [ANDROID] [NOTICE] [MESSAGING] deprecate RNFirebaseInstanceIdService in favour of FirebaseMessagingService's onNewToken event. Remove this service from your AndroidManifest.xml [IOS] [ANDROID] [INTERNAL] [MESSAGING] getToken & deleteToken now use Firebase InstanceID token management apis (with an FCM scope).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1510, #1754
Checklist
AndroidiOSe2etests added or updated in /tests/e2e/*Test Plan
Release Plan
RNFirebaseInstanceIdServicein favour ofFirebaseMessagingServices onNewToken event. Remove this service from yourAndroidManifest.xmlgetToken&deleteTokennow use Firebase InstanceID token management apis (with anFCMscope).Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter