fix(analytics): ts logEvent params arg should be optional #2822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Salakar
added
plugin: analytics
Salakar
approved these changes
Nov 25, 2019
Salakar
changed the title
Salakar
added a commit
that referenced
this pull request
Nov 25, 2019
andersondanilo
pushed a commit
to vixtech/react-native-firebase
that referenced
this pull request
Nov 9, 2020
…2822) * Fix analytics log event params not optional when it should be * Update Flow analytics log event type not in sync
andersondanilo
pushed a commit
to vixtech/react-native-firebase
that referenced
this pull request
Nov 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Looking at
packages/analytics/lib/index.js, thelogEventfunction takes adefault object valuefor the secondparamsparameter, and TS and Flow type comments mention that this parameter should be optional.We have been using
logEventmultiple times in our project without theparamsargument.Checklist
Release Plan
[TYPES] [ENHANCEMENT] [ANALYTICS] - Update typescript and flow types with logEvent optional parameter
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter