fix(auth, android): gracefully handle exception creating PhoneCredential

invertase · Nov 16, 2020 · 8ead604 · 8ead604
1 parent 532adb5
commit 8ead604
Showing 1 changed file with 11 additions and 4 deletions.
diff --git a/.../auth/android/src/main/java/io/invertase/firebase/auth/ReactNativeFirebaseAuthModule.java b/.../auth/android/src/main/java/io/invertase/firebase/auth/ReactNativeFirebaseAuthModule.java
@@ -991,10 +991,17 @@ public void confirmationResultConfirm(
     FirebaseApp firebaseApp = FirebaseApp.getInstance(appName);
     FirebaseAuth firebaseAuth = FirebaseAuth.getInstance(firebaseApp);
 
-    PhoneAuthCredential credential = PhoneAuthProvider.getCredential(
-      mVerificationId,
-      verificationCode
-    );
+    PhoneAuthCredential credential = null;
+    try {
+      credential = PhoneAuthProvider.getCredential(
+        mVerificationId,
+        verificationCode
+      );
+    } catch (Exception e) {
+      Log.d(TAG, "confirmationResultConfirm::getCredential::failure", e);
+      promiseRejectAuthException(promise, e);
+      return;
+    }
 
     firebaseAuth.signInWithCredential(credential).addOnCompleteListener(getExecutor(), task -> {
       if (task.isSuccessful()) {