Skip to content

Commit

Permalink
ci(patches): stabilize patch generation with node pin to v18.17.1
Browse files Browse the repository at this point in the history
above this version (including v20.8.0) there appears to be some I/O
asynchronicity where the file does not exist in time for the chmod command
on the file to be issued causing flaky patch generation failures

reproducible on linux
  • Loading branch information
mikehardy committed Oct 10, 2023
1 parent 3f0042e commit 755c692
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion .github/workflows/create_test_patches.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,12 @@ jobs:
# - make into an action, parameterize directories to pack, and package names to install
# - name patches w/PR as "semver prerelease" and SHA as "semver build info". Needs patch-package enhancement.

# FIXME: when github runner bumped from 18.17.1 to 18.18+ we started seeing template copy errors
# different files, could reproduce locally on linux with v18.18+ and v20.8.0. Pinning to
# prior version (18.17.1) to see if it stabilizes
- uses: actions/setup-node@v3
with:
node-version: 18
node-version: 18.17.1

- name: Set workflow variables
id: workflow-variables
Expand Down

0 comments on commit 755c692

Please sign in to comment.