Skip to content

Commit

Permalink
fix(app, sdks): adopt android-sdk 32.2.2 / ios-sdk 10.13.0
Browse files Browse the repository at this point in the history
- includes bump to crashlytics gradle plugin 2.9.8 - upstream issues all resolved I think
- includes bump to app-distribution gradle plugin to beta10
  • Loading branch information
mikehardy committed Aug 21, 2023
1 parent 79ec9ca commit 5484c0b
Show file tree
Hide file tree
Showing 7 changed files with 180 additions and 181 deletions.
3 changes: 1 addition & 2 deletions docs/crashlytics/android-setup.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,7 @@ buildscript {
// ..
dependencies {
// ..
// NOTE: 2.9.4 has issues: https://github.com/invertase/react-native-firebase/issues/6983
classpath 'com.google.firebase:firebase-crashlytics-gradle:2.9.2'
classpath 'com.google.firebase:firebase-crashlytics-gradle:2.9.8'
}
// ..
}
Expand Down
4 changes: 2 additions & 2 deletions docs/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ project.ext {
// Overriding Library SDK Versions
firebase: [
// Override Firebase SDK Version
bom : "32.1.0"
bom : "32.2.2"
],
],
])
Expand All @@ -233,7 +233,7 @@ Open your projects `/ios/Podfile` and add any of the globals shown below to the

```ruby
# Override Firebase SDK Version
$FirebaseSDKVersion = '10.12.0'
$FirebaseSDKVersion = '10.13.0'
```

Once changed, reinstall your projects pods via pod install and rebuild your project with `npx react-native run-ios`.
Expand Down
4 changes: 2 additions & 2 deletions packages/app-distribution/android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -87,11 +87,11 @@ dependencies {
api appProject
implementation platform("com.google.firebase:firebase-bom:${ReactNative.ext.getVersion("firebase", "bom")}")
// TODO remove the specific version once it is out of beta and participates in bom versioning
implementation 'com.google.firebase:firebase-appdistribution-api:16.0.0-beta08'
implementation 'com.google.firebase:firebase-appdistribution-api:16.0.0-beta10'
// TODO demonstrate how to only include this in certain build variants
// - perhaps have firebase.json name the variants to include, then roll through variants here and only
// add the dependency to variants that match? Or... (PRs welcome...)
// implementation 'com.google.firebase:firebase-appdistribution:16.0.0-beta08'
// implementation 'com.google.firebase:firebase-appdistribution:16.0.0-beta10'
}

ReactNative.shared.applyPackageVersion()
Expand Down
6 changes: 3 additions & 3 deletions packages/app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -73,16 +73,16 @@
},
"sdkVersions": {
"ios": {
"firebase": "10.12.0",
"firebase": "10.13.0",
"iosTarget": "11.0",
"macosTarget": "10.13"
},
"android": {
"minSdk": 19,
"targetSdk": 33,
"compileSdk": 33,
"firebase": "32.1.0",
"firebaseCrashlyticsGradle": "2.9.2",
"firebase": "32.2.2",
"firebaseCrashlyticsGradle": "2.9.8",
"firebasePerfGradle": "1.4.2",
"gmsGoogleServicesGradle": "4.3.15",
"playServicesAuth": "20.5.0"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ buildscript {
jcenter()
}
dependencies {
classpath 'com.google.firebase:firebase-crashlytics-gradle:2.9.2'
classpath 'com.google.firebase:firebase-crashlytics-gradle:2.9.8'
classpath("com.android.tools.build:gradle:4.1.0")
// NOTE: Do not place your application dependencies here; they belong
Expand Down
2 changes: 1 addition & 1 deletion tests/android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ buildscript {
classpath("com.facebook.react:react-native-gradle-plugin")
classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlinVersion"
classpath 'com.google.firebase:perf-plugin:1.4.2'
classpath 'com.google.firebase:firebase-crashlytics-gradle:2.9.2'
classpath 'com.google.firebase:firebase-crashlytics-gradle:2.9.8'
classpath 'com.google.firebase:firebase-appdistribution-gradle:4.0.0'
}
}
Expand Down
Loading

0 comments on commit 5484c0b

Please sign in to comment.