Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nonce generation and return for Android #153

Merged
merged 2 commits into from
Oct 20, 2020
Merged

Nonce generation and return for Android #153

merged 2 commits into from
Oct 20, 2020

Conversation

dburdan
Copy link
Contributor

@dburdan dburdan commented Oct 17, 2020

  • Added nonceEnabled field for Android
  • Added automatic nonce generation on Android if no string is provided
  • Added nonce to return data on Android

@dburdan dburdan mentioned this pull request Oct 17, 2020
Closed
mikehardy
mikehardy approved these changes Oct 20, 2020
View reviewed changes
Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry this sat so long, thanks @dburdan

@mikehardy mikehardy merged commit 01de17f into invertase:master Oct 20, 2020
@mikehardy
Copy link
Collaborator

released as https://github.com/invertase/react-native-apple-authentication/releases/tag/v2.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikehardy mikehardy mikehardy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dburdan @mikehardy