Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web admin: incorrect display for a date after 2038 #5828

Closed
nqb opened this issue Sep 24, 2020 · 4 comments
Closed

web admin: incorrect display for a date after 2038 #5828

nqb opened this issue Sep 24, 2020 · 4 comments

Comments

@nqb
Copy link
Contributor

nqb commented Sep 24, 2020

Describe the bug
If you generate a certificate for 7500 days (~20 years) using a PacketFence PKI template, frontend doesn't display correctly resulting date even if certificate contains correct date.

I assume this is because date is after 2038.

To Reproduce
Steps to reproduce the behavior:

  1. Create a CA in PacketFence PKI
  2. Create a template with 7500 days as Validity
  3. Generate a certificate using template

Screenshots
Capture d’écran de 2020-09-24 13-38-48

Expected behavior
Resulting date should be display.

Additional context
Even if it's only a display issue, you're not sure your certificate is valid. You have to download it and verify by hand if date is correct which is painful.

5000 days works.

@satkunas
Copy link
Contributor

Waiting on #5843 before resolving.

@fdurand
Copy link
Member

fdurand commented Sep 28, 2020

The date in the db is stored as zero (valid_until: 0000-00-00 00:00:00) it looks to be an issue with the version of golang we are using (golang/go#36654)

@fdurand
Copy link
Member

fdurand commented Sep 29, 2020

After talking to the team , we will probably need to limit the validity of a certificate to a maximum of 825 days (https://support.apple.com/en-ca/HT210176). @satkunas is it possible to limit the validity field in the form (CA and profile) ?

@julsemaan
Copy link
Collaborator

@satkunas will limit the validity in the frontend for the CA and the profile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants