Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception handling for BulkDeleteMixin #8205

Merged
merged 2 commits into from
Sep 29, 2024

Conversation

SchrodingersGat
Copy link
Member

Handle cases where id values or filters passed to bulk delete are invalid.

Based on exception reported by sentry.io for demo server

@SchrodingersGat SchrodingersGat added bug Identifies a bug which needs to be addressed api Relates to the API backport Apply this label to a PR to enable auto-backport action backport-to-0.16.x labels Sep 29, 2024
@SchrodingersGat SchrodingersGat added this to the 0.17.0 milestone Sep 29, 2024
Copy link

netlify bot commented Sep 29, 2024

Deploy Preview for inventree-web-pui-preview canceled.

Name Link
🔨 Latest commit 1bd146d
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/66f8b39f7486760008f6b70f

Copy link

codecov bot commented Sep 29, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 83.84%. Comparing base (390fec3) to head (1bd146d).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/backend/InvenTree/InvenTree/api.py 60.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8205      +/-   ##
==========================================
- Coverage   83.85%   83.84%   -0.01%     
==========================================
  Files        1161     1161              
  Lines       52171    52179       +8     
  Branches     1891     1891              
==========================================
+ Hits        43747    43750       +3     
- Misses       7951     7956       +5     
  Partials      473      473              
Flag Coverage Δ
backend 85.80% <60.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SchrodingersGat SchrodingersGat merged commit 33499d6 into inventree:master Sep 29, 2024
26 checks passed
@SchrodingersGat SchrodingersGat deleted the bulk-delete-fix branch September 29, 2024 05:37
github-actions bot pushed a commit that referenced this pull request Sep 29, 2024
* Exception handling for BulkDeleteMixin

* Fix unit test

(cherry picked from commit 33499d6)
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
0.16.x

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

SchrodingersGat added a commit that referenced this pull request Sep 29, 2024
* Exception handling for BulkDeleteMixin

* Fix unit test

(cherry picked from commit 33499d6)

Co-authored-by: Oliver <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Relates to the API backport Apply this label to a PR to enable auto-backport action backport-to-0.16.x bug Identifies a bug which needs to be addressed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant