Setting refactor #7404
Merged
Setting refactor #7404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for inventree-web-pui-preview canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7404 +/- ##
==========================================
- Coverage 83.86% 83.71% -0.16%
==========================================
Files 1057 1058 +1
Lines 46408 46582 +174
Branches 1386 1386
==========================================
+ Hits 38918 38994 +76
- Misses 7129 7224 +95
- Partials 361 364 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
matmair
approved these changes
Jun 4, 2024
- Work out what is going on in CI
- Cannot reproduce locally?
4 tasks
|
Not really sure - looks like the DB is not cleaned |
|
I cannot reproduce locally on a 3.9/sqlite setup... |
|
@matmair found the issue, a new setting was being created in the validator for a different setting. |
|
That is a tricky one to find! |
martonmiklos
pushed a commit
to martonmiklos/InvenTree
that referenced
this pull request
Jun 24, 2024
* Add helper functions to set/get settings * Refactor instances of get_setting * UPdates * Fix for task * Add debug messages - Work out what is going on in CI * add more debug - Cannot reproduce locally? * More debug... * Remove debug prints * Add better debug msg * Simplify unit test * Increase timeout for plugin tests * Update validator code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds helper functions for "get" and "set" for server-side settings.