-
-
Notifications
You must be signed in to change notification settings - Fork 782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added test statistics #7164
Added test statistics #7164
Conversation
✅ Deploy Preview for inventree-web-pui-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7164 +/- ##
==========================================
- Coverage 83.51% 83.46% -0.05%
==========================================
Files 1114 1119 +5
Lines 49376 49741 +365
Branches 1568 1629 +61
==========================================
+ Hits 41234 41517 +283
- Misses 7746 7797 +51
- Partials 396 427 +31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@martonmiklos can you please merge in the latest changes from master, and then I can review :) |
@SchrodingersGat Done. There are two things what might need to be looked into:
|
904132e
to
4d112b7
Compare
4d112b7
to
2e72631
Compare
@martonmiklos where are you at with this one? :) |
523f30b
to
2988e1a
Compare
@SchrodingersGat could you please help how to properly specify links with two parameters here: |
I would suggest that you make a "generic" test statistics endpoint, and rather than pinning it against specific database instances, pass those as query parameters you can filter by. Then you can have a single API endpoint and you can filter by:
|
a472731
to
4267b83
Compare
97b6198
to
ded5320
Compare
Hi there @martonmiklos!
|
Hi @matmair |
@martonmiklos the sqlite test is currently broken for python 3.12, we are still struggling to understand this one. Are you happy with the PR otherwise? |
Please fix the conflicts here and if you're satisfied with this I'm happy to merge it in |
@martonmiklos apologies but it looks like there are still some conflicts. If you can address this in the next couple of days, I'll hold off merging anything else so that we can get this one done :) |
Done! |
@martonmiklos a number of the frontend tests (playwright) are failing here - are they OK locally for you? |
I managed to get the PUI locally and discovered (together with an another issue in the old UI) that I messed up the API urls for PUI. Now it works locally. |
Ok, something is going on with the PUI tests, other PRs are failing too, when they should not be. I will have to look into this tomorrow |
@martonmiklos thanks for the hard work here :) I Have fixed the other PUI tests so this is good to go now. Thanks for the ongoing contributions! |
@martonmiklos when testing this on the "build order" page (for a part with only a small number of tests / results), there are a large number of queries running: I'll open a new issue to address this, I would appreciate it if you could look into optimizing the API / database queries. |
* fix style issue (inventree#7768) * Pin OAS action (inventree#7767) * [PUI] Bug fix for API forms (inventree#7758) * [PUI] Bug fix for API forms - Ensure that "blank" data does not get overriden with previous fields - Better logic for form data fetching * Playwright test fixes * Add extra fields to BOM export (inventree#7775) * Add extra fields to BOM export * Bump API version * Fix permissions for importing data (inventree#7776) * Added test statistics (inventree#7164) * Added test statistics Fixed inventree#5995 * Bump API version * Fix javascript varible scopes * Fix javascript exports * Remove duplicated import * Add files modified by the pre-commit scripts * Move test statistics API urls to a separate endpoint * Merge test-statistics urls * Undo unrelated changes * Formatting fix * Fix API urls for test statistics in PUI * Fix prefixing in test statistic functions --------- Co-authored-by: Oliver <[email protected]> * Add more names * split build and publish * add attestation and SBOM * format file * Add toplevel permissions --------- Co-authored-by: Oliver <[email protected]> Co-authored-by: Miklós Márton <[email protected]>
* add more admin testing * fix assertations * add test for importer admin * Add tests for #7164 * add common/attachment test * fix test * add tests * remove unused definition - the view is read only * Revert "remove unused definition - the view is read only" This reverts commit 4cad8d1. * more tests in report * Update tests.py * make lookup dynamic * make report assertation dynamic * add migration test * extend validation plugin tests * disable flaky test * Add test for barcode/uid transition * test reverse migration * cleanup new test * remove empty action * split and refactor API tests * refactor test * Add test for error conditions * fix double entry * more migration tests * also test no history * fix assertation * add another migration test * fix typo * fix manufacturer filter * test more filters * even more filter tests * move top level test to right place * add todos for tests that could be more expressive * add test for checking duplicate serials * ignore cautious catches
Fixed #5995
This PR adds test statistics views to the part and build pages which provides overview about the accumulated count of the passed/failed tests.