Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable the build output completion if are tests not passed #6057

Merged
merged 14 commits into from
Feb 17, 2024

Conversation

martonmiklos
Copy link
Contributor

Fixes #5037

Copy link

netlify bot commented Dec 8, 2023

Deploy Preview for inventree-web-pui-preview canceled.

Name Link
🔨 Latest commit 09dc491
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/65d13a4c5c26430007f569b3

InvenTree/common/models.py Outdated Show resolved Hide resolved
InvenTree/common/models.py Outdated Show resolved Hide resolved
InvenTree/build/serializers.py Outdated Show resolved Hide resolved
@SchrodingersGat SchrodingersGat added the build Build orders label Dec 10, 2023
@martonmiklos martonmiklos changed the title Add option to disable the build output completion if are tests not passed [WIP]Add option to disable the build output completion if are tests not passed Dec 10, 2023
@SchrodingersGat
Copy link
Member

@martonmiklos we will need some unit tests here to ensure that the new checks work as expected. And to ensure that the correct errors are reported via the API

@SchrodingersGat SchrodingersGat added this to the 0.14.0 milestone Dec 18, 2023
@SchrodingersGat SchrodingersGat added the api Relates to the API label Dec 18, 2023
@SchrodingersGat
Copy link
Member

@martonmiklos have you had a chance to look at this?

@martonmiklos
Copy link
Contributor Author

@martonmiklos have you had a chance to look at this?

Yes I started to write tests, but have not finished them yet.
However I have not started looking into the PUI config page yet.

@martonmiklos martonmiklos changed the title [WIP]Add option to disable the build output completion if are tests not passed Add option to disable the build output completion if are tests not passed Dec 23, 2023
InvenTree/build/models.py Outdated Show resolved Hide resolved
InvenTree/build/serializers.py Outdated Show resolved Hide resolved
@SchrodingersGat
Copy link
Member

@martonmiklos i am back on deck now, so if you can address the requirements above I'm happy to review again :)

@SchrodingersGat
Copy link
Member

@martonmiklos any progress on this one? :)

@SchrodingersGat
Copy link
Member

@martonmiklos it would be great to be able to get this into 0.14.0 - can you please address the outstanding issues? :)

@martonmiklos
Copy link
Contributor Author

martonmiklos commented Feb 15, 2024

@martonmiklos it would be great to be able to get this into 0.14.0 - can you please address the outstanding issues? :)

@SchrodingersGat I do not want to be fussing on this one, but I am still under the impression that the non-trackable (serial number less) parts cannot have tests assigned. If that's true adding the serial number to the error messages makes sense in most cases.

If you say you do not want to see the serial in the error message I can understand and will approve the decision, (and implement changes accordingly) just I have not get exact feedback for my claims (in the thread above) yet ;)

@SchrodingersGat
Copy link
Member

@martonmiklos ok I see the point there, the subtlety was lost on me before. I'll reply inline to the error message comments

@SchrodingersGat SchrodingersGat merged commit ad1c1ae into inventree:master Feb 17, 2024
26 checks passed
@SchrodingersGat
Copy link
Member

@martonmiklos thanks for the contribution :)

@SchrodingersGat SchrodingersGat added the enhancement This is an suggested enhancement or new feature label Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Relates to the API build Build orders enhancement This is an suggested enhancement or new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] Block Build Orders until Tests are completed
3 participants