-
-
Notifications
You must be signed in to change notification settings - Fork 782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to disable the build output completion if are tests not passed #6057
Conversation
✅ Deploy Preview for inventree-web-pui-preview canceled.
|
@martonmiklos we will need some unit tests here to ensure that the new checks work as expected. And to ensure that the correct errors are reported via the API |
@martonmiklos have you had a chance to look at this? |
Yes I started to write tests, but have not finished them yet. |
…or message in the case if multiple outputs having incomplete tests
@martonmiklos i am back on deck now, so if you can address the requirements above I'm happy to review again :) |
@martonmiklos any progress on this one? :) |
@martonmiklos it would be great to be able to get this into |
@SchrodingersGat I do not want to be fussing on this one, but I am still under the impression that the non-trackable (serial number less) parts cannot have tests assigned. If that's true adding the serial number to the error messages makes sense in most cases. If you say you do not want to see the serial in the error message I can understand and will approve the decision, (and implement changes accordingly) just I have not get exact feedback for my claims (in the thread above) yet ;) |
@martonmiklos ok I see the point there, the subtlety was lost on me before. I'll reply inline to the error message comments |
Simplify error message
Formatting fix
More style fixes
Remove empty line
@martonmiklos thanks for the contribution :) |
Fixes #5037