tests: flexible registration

invenio_accounts/views/rest.py

@@ -131,7 +131,6 @@ def create_blueprint(app):
 class FlaskParser(FlaskParserBase):
     """Parser to add FieldError to validation errors."""
 
-    # TODO: Add error codes to all messages (e.g. 'user-already-exists')
     def handle_error(self, error, *args, **kwargs):
         """Handle errors during parsing."""
         if isinstance(error, ValidationError):

tests/conftest.py

@@ -147,6 +147,36 @@ def app_with_redis_url(request):
     yield app
 
 
+@pytest.fixture()
+def app_with_flexible_registration(request):
+    """Flask application fixture with Invenio Accounts."""
+    from webargs import fields
+    from invenio_accounts.views.rest import RegisterView, use_kwargs
+
+    class MyRegisterView(RegisterView):
+
+        post_args = {
+            **RegisterView.post_args,
+            'active': fields.Boolean(required=True)
+        }
+
+        @use_kwargs(post_args)
+        def post(self, **kwargs):
+            """Register a user."""
+            return super(MyRegisterView, self).post(**kwargs)
+
+    api_app = _app_factory()
+    InvenioREST(api_app)
+    InvenioAccountsREST(api_app)
+
+    api_app.config['ACCOUNTS_REST_AUTH_VIEWS']['register'] = MyRegisterView
+
+    api_app.register_blueprint(create_blueprint(api_app))
+
+    _database_setup(api_app, request)
+    yield api_app
+
+
 @pytest.fixture
 def script_info(app):
     """Get ScriptInfo object for testing CLI."""

tests/test_views_rest.py

@@ -174,6 +174,27 @@ def test_registration_view(api):
             assert res.status_code == 200
 
 
+def test_custom_registration_view(app_with_flexible_registration):
+    app = app_with_flexible_registration
+    with app.app_context():
+        create_test_user(email='[email protected]')
+        db.session.commit()
+        with app.test_client() as client:
+            url = url_for('invenio_accounts_rest_auth.register')
+
+            # Missing custom field
+            res = client.post(url, data=dict(
+                email='[email protected]', password='123456'))
+            assert_error_resp(res, (
+                ('active', 'required'),
+            ))
+
+            # Successful registration
+            res = client.post(url, data=dict(
+                email='[email protected]', password='123456', active=True))
+            assert res.status_code == 200
+
+
 def test_logout_view(api):
     app = api
     with app.app_context():