nginx: add "application/javascript" MIME type for mjs files #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* otherwise, nginx may fall back to using "application/octet-stream" which browsers may not like
max-moser
force-pushed
the
mm/nginx-mjs
branch
from
6b5992a to
6014f26
Compare
|
Very similar issue (which also served as inspiration for this PR): storybookjs/storybook#20157 |
egabancho
added a commit
to egabancho/helm-invenio
that referenced
this pull request
Dec 12, 2024
egabancho
added a commit
to egabancho/helm-invenio
that referenced
this pull request
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise,
nginxmay fall back to using "application/octet-stream" which browsers may not like.For instance,
pdfjs-distv4 usesmjsfiles, which is used by the new PDF previewer inInvenio-Previewer.The files are transferred correctly, but because the files are reported to have the wrong MIME type they can get blocked by the browser.
This PR tells
nginxthatmjsfiles are, likejsfiles, to be reported asapplication/javascript.