Adding a default value inside the custom property statements #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kendallgassner
commented
Nov 13, 2020
kendallgassner
commented
Nov 13, 2020
hipstersmoothie
requested changes
Nov 13, 2020
There was a problem hiding this comment.
I think we can improve this for when the variable is used multiple times. I think it would also be cool to add a config option that disables the inlining. Some people may want to expose those variables for consumers of the components. the default can be to inline. The option could be called inlineRootThemeVariables with the default being true
|
|
||
| .mint { | ||
| --color: teal | ||
| } |
src/modern/index.ts
Outdated
Comment on lines
101
to
104
| const inlineRootThemeVariables = | ||
| typeof options.inlineRootThemeVariables === 'undefined' | ||
| ? true | ||
| : options.inlineRootThemeVariables; |
There was a problem hiding this comment.
Suggested change
| const inlineRootThemeVariables = | |
| typeof options.inlineRootThemeVariables === 'undefined' | |
| ? true | |
| : options.inlineRootThemeVariables; | |
| const inlineRootThemeVariables = options.inlineRootThemeVariables ?? options.inlineRootThemeVariables; |
hipstersmoothie
requested changes
Nov 16, 2020
|
🚀 PR was released in v2.2.2 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed
Why
Todo:
yarn all-contributors add [name] [type]) see https://github.com/all-contributors/all-contributors/blob/master/docs/cli/usage.md