Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new test cases to increase code coverage #31

Merged
merged 5 commits into from
Oct 2, 2020
Merged

Added new test cases to increase code coverage #31

merged 5 commits into from
Oct 2, 2020

Conversation

ratnamal
Copy link
Contributor

@ratnamal ratnamal commented Oct 2, 2020 •
edited
Loading

What Changed

Add new tests in legacy and modern test files
Fixed an issue where field forceSingleTheme is taking boolean value instead of a string in a few tests in legacy.test.ts file

Why

To increase code coverage

Issue: #18

Todo:

  • Add tests
  • Add docs
  • Add yourself to contributors (run yarn contributors:add)

@ratnamal
Copy link
Contributor Author

ratnamal commented Oct 2, 2020

Original coverage:
Coverage on master branch

Coverage after adding tests:
Coverage after adding tests

@ratnamal ratnamal mentioned this pull request Oct 2, 2020
Closed
tylerkrupicka
tylerkrupicka approved these changes Oct 2, 2020
View reviewed changes
Copy link
Contributor

@tylerkrupicka tylerkrupicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! This is looking great.

Can you fix the conflicts (we had some new contributors), and then I can merge.

@ratnamal
Copy link
Contributor Author

ratnamal commented Oct 2, 2020 •
edited
Loading

Thanks for the contribution! This is looking great.

Can you fix the conflicts (we had some new contributors), and then I can merge.

@tylerkrupicka Fixed the merge conflicts. Thank you for the review

@tylerkrupicka tylerkrupicka merged commit 0da8b77 into intuit:master Oct 2, 2020
@tylerkrupicka tylerkrupicka added skip-release Preserve the current version when merged hacktoberfest labels Oct 2, 2020
@hipstersmoothie
Copy link
Contributor

🚀 PR was released in v2.1.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerkrupicka tylerkrupicka tylerkrupicka approved these changes

Assignees
No one assigned
Labels
hacktoberfest released skip-release Preserve the current version when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ratnamal @hipstersmoothie @tylerkrupicka