Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: next version calculation for tags that contain a name/prefix #2436

Merged
merged 4 commits into from
Feb 24, 2024

Conversation

restfulhead
Copy link
Contributor

What Changed

Fixes #2435

Why

Todo:

  • Add tests
  • Add docs

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major

Copy link
Collaborator

@hipstersmoothie hipstersmoothie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add tests?

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 80.56%. Comparing base (6774575) to head (fcad699).
Report is 4 commits behind head on main.

Files Patch % Lines
packages/core/src/release.ts 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2436      +/-   ##
==========================================
- Coverage   80.64%   80.56%   -0.09%     
==========================================
  Files          69       69              
  Lines        5678     5680       +2     
  Branches     1276     1277       +1     
==========================================
- Hits         4579     4576       -3     
- Misses        718      719       +1     
- Partials      381      385       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@restfulhead
Copy link
Contributor Author

Could you add tests?

Sure, done.

@hipstersmoothie hipstersmoothie added the patch Increment the patch version when merged label Feb 24, 2024
@hipstersmoothie hipstersmoothie merged commit ccd2092 into intuit:main Feb 24, 2024
5 of 9 checks passed
Copy link

🚀 PR was released in v11.1.1 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing version in CHANGELOG.md: Calculating the next version fails if tag contains a name/prefix
2 participants