Add comment ARIA #56
Open
Add comment ARIA #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ], | ||
| "body": [ | ||
| "role='comment'", | ||
| "aria-details={$1}" |
There was a problem hiding this comment.
this parts tough because the aria-details actually should be located on role="mark"
<span role="mark" aria-details="thread-1">end of the guitar solo</span>, before fading away sharply.</p>
<div role="comment" id="thread-1" data-author="chris">
<h3>Chris said</h3>
<p class="comment-text">I really think this moment could use more cowbell.</p>
<p><time datetime="2019-03-30T19:29">March 30 2019, 19:29</time></p>
</div>
There was a problem hiding this comment.
what we end up wanting is an id={} paired with role comment
and a description explaining that when you use role=comment you also should use role=mark
There was a problem hiding this comment.
Updated the changes! Let me know what you think!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed
Added Comment ARIA
Why
Added for #50
Allowing developers to add an ARIA role for comments in their application.
Todo: