Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Aria: Loading Spinner #34

Merged
merged 2 commits into from
Oct 1, 2021
Merged

Add Aria: Loading Spinner #34

merged 2 commits into from
Oct 1, 2021

Conversation

aylinmarie
Copy link

@aylinmarie aylinmarie commented Oct 1, 2021 •
edited
Loading

What Changed

  • Added LoadingAria snippet (includes role="status", aria-live="polite", aria-label="Loading" and aria-busy attributes
  • Updated README.md to include this PR's changes

Why

For issue: #32

Provide guidance on aria attributes needed for loading spinners and indicators.

Todo:

  • Add Semantic Version Label
  • Add tests
  • Add docs

@kendallgassner
Copy link
Collaborator

✨

@kendallgassner kendallgassner added the minor Increment the minor version when merged label Oct 1, 2021
@kendallgassner kendallgassner merged commit 1b1e622 into intuit:master Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kendallgassner kendallgassner kendallgassner approved these changes

Assignees
No one assigned
Labels
minor Increment the minor version when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aylinmarie @kendallgassner