Added ARIA: TableAria #18 and CellAria #14 #26
Conversation
| "width=''", | ||
| "bgcolor=''", | ||
| ], | ||
| "description": "Add `role='radio'` to a checkable interactive control. Use radio in place of checkbox if only one item in a group can be checked. Add `aria-checked` to indicate the state of the checkbox." |
There was a problem hiding this comment.
whoops copy/paster error!
| "TableAria", | ||
| ], | ||
| "body": [ | ||
| "aria-colcount=''", |
There was a problem hiding this comment.
I think you forgot role=table?
There was a problem hiding this comment.
except this all things are okay??
There was a problem hiding this comment.
^ I have been adding the ones that mozilla specifies
Amishakumari544
changed the title
|
@kendallgassner mam please review this if it is fine or not. |
package-lock.json
Outdated
| @@ -0,0 +1,6621 @@ | |||
| { | |||
| "name": "accessibility-snippets", | |||
There was a problem hiding this comment.
can you remove this file :) we use yarn.lock
There was a problem hiding this comment.
also this should not be included: accessibility-snippets-0.0.15.vsix
would be awesome if you added these to the gitignore
| "TableAria", | ||
| ], | ||
| "body": [ | ||
| "aria-colcount=''", |
There was a problem hiding this comment.
^ I have been adding the ones that mozilla specifies
| "CellAria", | ||
| ], | ||
| "body": [ | ||
| "role='cell'", |
There was a problem hiding this comment.
Sorry one thing i forgot to mention you shouldnt use bot the quotes and the brackets at the same time
quotes are for string values like aria-label for example.
and {} are for things like numbers
variable={$1} => variable={}
variableString='$1' => variable=''
| "role='table'", | ||
| "aria-colcount='{$1}'", | ||
| "aria-rowcount={-1}", | ||
| "aria-label ={}", |
What Changed
Readme File with TableAria Content
Readme File with CellAria Content
Added Table Role
Added Cell Role
Why
This PR is in reference to #14 and #18 which required adding Table and Cell accessibility feature.