Added ARIA:banner role #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you so much for the pr! Would you mind adding banner aria to the readme :) |
|
closes(#13) |
| ], | ||
| "body":[ | ||
| "role='banner'", | ||
| "tabIndex={0}" |
There was a problem hiding this comment.
no need to add a tabIndex on this aria role
tabIndex='0' makes components focusable typically we add tabIndex to form elements like select, inputs to allow users who navigate using the keyboard to be able to interact with the element.
Since banners are typically containers for other elements we do not need to add tabIndex.
There was a problem hiding this comment.
OK Sure! Then I am removing tabIndex=0 and adding banner aria to readme.
Co-authored-by: Kendall Gassner <[email protected]>
|
Done! Thank You For The Help! |
kendallgassner
approved these changes
Jul 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed
Added the ARIA: banner role in react-snippets (#13)
Why
Todo: