Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Step StopBehavior to exit script at end of step #317

Merged
merged 4 commits into from
Apr 4, 2024

Conversation

Zakaria-Kofiro
Copy link
Collaborator

Fix Step StopBehavior to exit script at end of step

This fixes a flaw in the Step StopBehavior logic where after being sent a stop command to a job configured with Stop Behavior : Step, the user would continue executing the remaining steps in the test plan instead of returning and exiting at the end of step.

Please make sure these check boxes are checked before submitting

  • ** Squashed Commits **
  • ** All Tests Passed ** - mvn clean test -P default

** PR review process **

  • Requires one +1 from a reviewer
  • Repository owners will merge your PR once it is approved.

Copy link
Collaborator

@kevin-mcgoldrick kevin-mcgoldrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zakaria-Kofiro Zakaria-Kofiro merged commit 749f9a6 into master Apr 4, 2024
@Zakaria-Kofiro Zakaria-Kofiro deleted the zkofiro/step-stopbehavior-fix branch April 4, 2024 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants