[SRE-30501] Remove logResponse String builder during all http requests #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zakaria-Kofiro
force-pushed
the
SRE-30501
branch
from
3119938
to
3050bc2
Compare
…0501 * 'SRE-30501' of https://github.com/intuit/Tank: log exception message in testplanstarter and add OOM exception log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove logResponse String builder during all http requests
This change only creates the response log message only if using with Agent Debugger Tool and if Log Level is set to
DEBUGinstead of creating it by default on each step - decreasing the memory allocated for the log message string per agent thread. It also now correctly logs error messages fromTestPlanStarter, including catching OOM exceptions.BEFORE
AFTER
Please make sure these check boxes are checked before submitting
mvn clean test -P default** PR review process **