Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ScriptProcessor Bean to @RequestScoped #308

Merged
merged 6 commits into from
Apr 4, 2024
Merged

Update ScriptProcessor Bean to @RequestScoped #308

merged 6 commits into from
Apr 4, 2024

Conversation

kevin-mcgoldrick
Copy link
Collaborator

Update ScriptProcessor Bean to @RequestScoped

Please make sure these check boxes are checked before submitting

  • ** Squashed Commits **
  • ** All Tests Passed ** - mvn clean test -P default

** PR review process **

  • Requires one +1 from a reviewer
  • Repository owners will merge your PR once it is approved.

@kevin-mcgoldrick
Update ScriptProcessor Bean to @RequestScoped
b15a903
@kevin-mcgoldrick
Merge branch 'master' into SRE-30410
ce2ac83 
* master:
  Bump org.apache.tomcat.embed:tomcat-embed-core from 10.1.16 to 10.1.19 (#307)
  Reset Content-Type after StringEntity (#306)
@kevin-mcgoldrick kevin-mcgoldrick marked this pull request as ready for review March 15, 2024 18:15
Zakaria-Kofiro
Zakaria-Kofiro requested changes Mar 15, 2024
View reviewed changes
Copy link
Collaborator

@Zakaria-Kofiro Zakaria-Kofiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated script upload via API no longer spiking memory usage, but ran into issues uploading scripts via Tank UI with ScriptServiceUtil:389 - Error unmarshalling script: null error

@kevin-mcgoldrick
Copy link
Collaborator Author

kevin-mcgoldrick commented Mar 15, 2024 •
edited
Loading

Excellent find. That must be why it's Dependent. I'll try the other approach in QA.

Validated script upload via API no longer spiking memory usage, but ran into issues uploading scripts via Tank UI with ScriptServiceUtil:389 - Error unmarshalling script: null error

Zakaria-Kofiro
Zakaria-Kofiro approved these changes Apr 4, 2024
View reviewed changes
Copy link
Collaborator

@Zakaria-Kofiro Zakaria-Kofiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zakaria-Kofiro
Copy link
Collaborator

Validated script upload via API no longer spiking memory usage, but ran into issues uploading scripts via Tank UI with ScriptServiceUtil:389 - Error unmarshalling script: null error

Change working as intended, this error is unrelated to the change, arising from re-uploading a specific unfiltered script. It also throws the same error when uploading on master branch.

@Zakaria-Kofiro Zakaria-Kofiro merged commit 30f2a10 into master Apr 4, 2024
@Zakaria-Kofiro Zakaria-Kofiro deleted the SRE-30410 branch April 4, 2024 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zakaria-Kofiro Zakaria-Kofiro Zakaria-Kofiro approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevin-mcgoldrick @Zakaria-Kofiro