Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize Agents Before Starting Load #294

Merged
merged 13 commits into from
Jan 12, 2024

Conversation

Zakaria-Kofiro
Copy link
Collaborator

@Zakaria-Kofiro Zakaria-Kofiro commented Jan 12, 2024

Initialize Agents Before Starting Load
This feature allows all agents for a specific job to check in before starting load to ensure all agents are ready to start at the same time, especially when dealing with a large number of instances.

Please make sure these check boxes are checked before submitting

  • ** Squashed Commits **
  • ** All Tests Passed ** - mvn clean test -P default

** PR review process **

  • Requires one +1 from a reviewer
  • Repository owners will merge your PR once it is approved.

@Zakaria-Kofiro Zakaria-Kofiro marked this pull request as ready for review January 12, 2024 17:26
@@ -48,7 +48,7 @@ public class TestPlanStarter implements Runnable {
private Dimension jobId;
private boolean standalone;
private Date send = new Date();
private static final int interval = 30; // SECONDS
private static final int interval = 15; // SECONDS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Zakaria-Kofiro Small but can we update this line as well to reflect the changed value on line 432:
send = DateUtils.addSeconds(new Date(), interval); // 30 SECONDS

@shawn-h-park shawn-h-park self-requested a review January 12, 2024 22:31
@Zakaria-Kofiro Zakaria-Kofiro merged commit 0ff242d into master Jan 12, 2024
@Zakaria-Kofiro Zakaria-Kofiro deleted the zkofiro/initialize-agents-before-start branch January 12, 2024 23:00
kevin-mcgoldrick added a commit that referenced this pull request Feb 1, 2024
* master:
  update position pointer to loop subnet list (#295)
  Initialize Agents Before Starting Load (#294)
  Implement Retry for Agents Starting HttpServer (#293)
  allow any ramp rate value per agent (#292)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants