-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initialize Agents Before Starting Load #294
Merged
Zakaria-Kofiro
merged 13 commits into
master
from
zkofiro/initialize-agents-before-start
Jan 12, 2024
Merged
Initialize Agents Before Starting Load #294
Zakaria-Kofiro
merged 13 commits into
master
from
zkofiro/initialize-agents-before-start
Jan 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ -48,7 +48,7 @@ public class TestPlanStarter implements Runnable { | |||
private Dimension jobId; | |||
private boolean standalone; | |||
private Date send = new Date(); | |||
private static final int interval = 30; // SECONDS | |||
private static final int interval = 15; // SECONDS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Zakaria-Kofiro Small but can we update this line as well to reflect the changed value on line 432:
send = DateUtils.addSeconds(new Date(), interval); // 30 SECONDS
shawn-h-park
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initialize Agents Before Starting Load
This feature allows all agents for a specific job to check in before starting load to ensure all agents are ready to start at the same time, especially when dealing with a large number of instances.
Please make sure these check boxes are checked before submitting
mvn clean test -P default
** PR review process **